Add filename to AttachmentSizeExceeded error message #360
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Add filename to AttachmentSizeExceeded error messageBug Fix🐛 Bug Fix: Enhanced the file size exceeded error message to include the filename, improving user experience when uploading multiple files. Changes
GitHub Issues
PR Bot InformationVersion:
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
I identified one critical bug in this pull request:
The database query at line 208 lacks proper error handling and can fail in several scenarios:
- When
req.data.up__IDis undefined or null (common in direct attachment operations) - When the query returns no results, causing destructuring to fail on
undefined - The query assumes a parent-child relationship that may not always exist
The fix should prioritize using req.data.filename (which is typically available during upload) and only fall back to a database query when necessary, with proper null-safety checks. This prevents runtime errors while still achieving the goal of including the filename in error messages.
The i18n message change itself is good and improves user experience by providing more context about which file exceeded the limit.
PR Bot Information
Version: 1.17.26 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- LLM:
anthropic--claude-4.5-sonnet - Correlation ID:
165d4c00-f5ee-11f0-84bc-92804ea13d09 - Event Trigger:
pull_request.opened
KoblerS
force-pushed
the
add-filename-to-error-message
branch
from
468ec76 to
a505596
Compare
KoblerS
force-pushed
the
add-filename-to-error-message
branch
from
a505596 to
a2525cd
Compare
…ce error messages with filenames
| const fs = require('fs/promises') | ||
| const { validateAttachmentSize } = require('../../lib/generic-handlers'); | ||
| const { newIncident } = require('../utils/testUtils'); | ||
| const { join } = cds.utils.path |
Fixes #359