Skip to content

Delete duplicate scanning #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-pSAP wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Delete duplicate scanning #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65d1bc8
Await scanning
eric-pSAP May 6, 2026
a84c6bf
Changelog
eric-pSAP May 6, 2026
af46975
Remove deadlock
eric-pSAP May 6, 2026
bf2be97
Remove cds.tx
eric-pSAP May 6, 2026
00191fb
Changelog
eric-pSAP May 6, 2026
183e9ab
Merge branch 'main' into awaitScanning
eric-pSAP May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).
The format is based on [Keep a Changelog](http://keepachangelog.com/).

## Version 3.13.0

### Fixed

- Remove extra function setting status to scanning to avoid race conditions.

## Version 3.12.1

### Added
Expand Down
6 changes: 0 additions & 6 deletions lib/generic-handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,6 @@ async function rescan(req, attachmentId) {
// No scan or scan expired: trigger scan and reject
const malwareScanner = await cds.connect.to("malwareScanner")

// Set status to Scanning and commit before emitting event to prevent race conditions
cds.tx(
async () => await malwareScanner.updateStatus(target, keys, "Scanning"),
)

// Trigger scanning in separate transaction as req.reject closes the current transaction
cds.spawn(async () => {
await malwareScanner.emit("ScanAttachmentsFile", {
target,
Expand Down
Loading