Skip to content

fix(security): ci#443

Merged
eric-pSAP merged 4 commits intomainfrom
fix-ci
May 7, 2026
Merged

fix(security): ci#443
eric-pSAP merged 4 commits intomainfrom
fix-ci

Conversation

@SirSimon04
Copy link
Copy Markdown
Contributor

@SirSimon04 SirSimon04 commented May 6, 2026

fix(security): Pin GitHub Actions to Full Commit SHAs

🔒 Security: Pinned all GitHub Actions dependencies to their full commit SHAs to prevent supply chain attacks, and added Dependabot configuration for automated dependency updates.

Changes

  • .github/dependabot.yml: New file — Added Dependabot configuration to automatically track and update both npm and github-actions dependencies on a weekly schedule with a 7-day cooldown.

  • .github/actions/integration-tests/action.yml: Pinned actions/checkout and actions/setup-node to full commit SHAs. Refactored CF authentication to use environment variables instead of inline ${{ inputs.* }} expressions (avoids secret/input leakage in logs), removed the debug log line that printed CF_API, and split cf login into separate cf api, cf auth, and cf target commands.

  • .github/workflows/check-changelog.yml: Pinned tarides/changelog-check-action to full commit SHA.

  • .github/workflows/issue.yml: Pinned actions/github-script to full commit SHA.

  • .github/workflows/lint.yml: Pinned actions/setup-node and actions/checkout to full commit SHAs in both lint and prettier jobs.

  • .github/workflows/release.yml: Pinned actions/checkout, actions/setup-node, martinbeentjes/npm-get-version-action, schwma/parse-changelog-action, and ncipollo/release-action to full commit SHAs.

  • .github/workflows/stale.yml: Pinned actions/stale to full commit SHA.

  • .github/workflows/test.yml: Pinned actions/checkout and actions/setup-node to full commit SHAs across all jobs. Replaced the local action reference for integration tests with the fully-qualified cap-js/attachments/.github/actions/integration-tests@main path, removing the redundant checkout step that preceded it.

  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.20.37

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • Summary Prompt: Default Prompt
  • Output Template: Default Template
  • Correlation ID: 3586f350-fe23-4b87-b318-995d0dcdf287

@SirSimon04 SirSimon04 requested a review from a team as a code owner May 6, 2026 09:57
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR makes good progress on supply-chain security by pinning all action references to immutable commit SHAs and moving CF credentials out of the command line into environment variables. However, three issues were flagged: the integration-tests composite action is still referenced via the mutable @main branch (undermining the whole SHA-pinning effort), cf auth should pass credentials as explicit arguments rather than relying silently on env-var forwarding, and both lint.yml jobs have setup-node invoked before checkout, which is the wrong order.

PR Bot Information

Version: 1.20.37

  • Event Trigger: pull_request.opened
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 3586f350-fe23-4b87-b318-995d0dcdf287

Comment thread .github/workflows/test.yml
Comment thread .github/actions/integration-tests/action.yml
Comment thread .github/workflows/lint.yml Outdated
Comment thread .github/workflows/lint.yml Outdated
Copy link
Copy Markdown
Member

@KoblerS KoblerS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! :)

@eric-pSAP eric-pSAP merged commit 9e21c22 into main May 7, 2026
23 checks passed
@eric-pSAP eric-pSAP deleted the fix-ci branch May 7, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants