Conversation
Contributor
There was a problem hiding this comment.
The PR makes good progress on supply-chain security by pinning all action references to immutable commit SHAs and moving CF credentials out of the command line into environment variables. However, three issues were flagged: the integration-tests composite action is still referenced via the mutable @main branch (undermining the whole SHA-pinning effort), cf auth should pass credentials as explicit arguments rather than relying silently on env-var forwarding, and both lint.yml jobs have setup-node invoked before checkout, which is the wrong order.
PR Bot Information
Version: 1.20.37
- Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
3586f350-fe23-4b87-b318-995d0dcdf287
maxieckert-sap
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(security): Pin GitHub Actions to Full Commit SHAs
🔒 Security: Pinned all GitHub Actions dependencies to their full commit SHAs to prevent supply chain attacks, and added Dependabot configuration for automated dependency updates.
Changes
.github/dependabot.yml: New file — Added Dependabot configuration to automatically track and update bothnpmandgithub-actionsdependencies on a weekly schedule with a 7-day cooldown..github/actions/integration-tests/action.yml: Pinnedactions/checkoutandactions/setup-nodeto full commit SHAs. Refactored CF authentication to use environment variables instead of inline${{ inputs.* }}expressions (avoids secret/input leakage in logs), removed the debug log line that printedCF_API, and splitcf logininto separatecf api,cf auth, andcf targetcommands..github/workflows/check-changelog.yml: Pinnedtarides/changelog-check-actionto full commit SHA..github/workflows/issue.yml: Pinnedactions/github-scriptto full commit SHA..github/workflows/lint.yml: Pinnedactions/setup-nodeandactions/checkoutto full commit SHAs in bothlintandprettierjobs..github/workflows/release.yml: Pinnedactions/checkout,actions/setup-node,martinbeentjes/npm-get-version-action,schwma/parse-changelog-action, andncipollo/release-actionto full commit SHAs..github/workflows/stale.yml: Pinnedactions/staleto full commit SHA..github/workflows/test.yml: Pinnedactions/checkoutandactions/setup-nodeto full commit SHAs across all jobs. Replaced the local action reference for integration tests with the fully-qualifiedcap-js/attachments/.github/actions/integration-tests@mainpath, removing the redundant checkout step that preceded it.PR Bot Information
Version:
1.20.37anthropic--claude-4.6-sonnetpull_request.opened3586f350-fe23-4b87-b318-995d0dcdf287