DebugInfo: Emit as "C++" rather than "C" #6361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffromer
approved these changes
Nov 12, 2025
toolchain/lower/context.cpp
Outdated
| llvm::DIFile* compile_unit_file = di_builder.createFile(module_name, ""); | ||
| // TODO: Introduce a new language code for Carbon. C works well for now since | ||
| // it's something debuggers will already know/have support for at least. | ||
| // Probably have to bump to C++ at some point for virtual functions, |
Contributor
There was a problem hiding this comment.
It looks like this is done now?
Contributor
Author
There was a problem hiding this comment.
ah, yep - thanks! updated the comment in 9423c63
geoffromer
approved these changes
Nov 18, 2025
This helps at least lldb handle calling functions (currently the debug
info describes every function as `void()`, so no parameters or return
values are supported) - seems gdb and lldb both depend on demangling to
varying degrees in C code (marking a function as "prototyped" in C in
DWARF does seem to also address this problem).
Given:
fn PrintThree() {
Core.Print(3);
}
Before:
(lldb) p PrintThree()
error: Couldn't look up symbols:
PrintThree
Hint: The expression tried to call a function that is not present in
the target, perhaps because it was optimized out by the compiler.
After:
(lldb) p PrintThree()
3
(lldb)
dwblaikie
force-pushed
the
debug_info_lang_c_plus_plus
branch
from
9423c63 to
3ce398a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps at least lldb handle calling functions (currently the debug
info describes every function as
void(), so no parameters or returnvalues are supported) - seems gdb and lldb both depend on demangling to
varying degrees in C code (marking a function as "prototyped" in C in
DWARF does seem to also address this problem).
Given:
Before:
After: