Skip to content

Use GlobalReplace for replacing unexpected insts with a regex #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2025
Merged

Use GlobalReplace for replacing unexpected insts with a regex #6401

merged 3 commits into from
Nov 19, 2025
+2 −2

Conversation

@danakj
Copy link
Contributor

@danakj danakj commented Nov 19, 2025 •
edited
Loading

Replace all unexpected instruction ids in a line, not just the first one. Otherwise you get something like this:

// CHECK:STDOUT: impl @<null name>: <unexpected>.inst{{[0-9A-F]+}}.loc20_6 as <unexpected>.inst6000002E.loc20_11;

@danakj danakj requested a review from a team as a code owner November 19, 2025 17:31
@danakj danakj requested review from geoffromer and removed request for a team November 19, 2025 17:31
@danakj
Copy link
Contributor Author

danakj commented Nov 19, 2025

I rebased this on top of #6400 so that we can see the test change in this PR. global-replace is the first new commit.

jonmeow
jonmeow approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks.

@danakj danakj enabled auto-merge November 19, 2025 22:20
@danakj danakj added this pull request to the merge queue Nov 19, 2025
Merged via the queue into carbon-language:trunk with commit 2b30157 Nov 19, 2025
8 checks passed
@danakj danakj deleted the global-replace branch November 19, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffromer geoffromer geoffromer approved these changes

@jonmeow jonmeow jonmeow approved these changes

Assignees

No one assigned

Labels

toolchain

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danakj @geoffromer @jonmeow