Extract the CC1 logic to third_party location
#6405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that the CC1 logic is directly extracted from Clang. There are probably some other places in the toolchain we should extract code like this where we're replicating and customizing logic from LLVM, but wanted to start here.
josh11b
approved these changes
Nov 20, 2025
chandlerc
added a commit
to chandlerc/carbon-lang
that referenced
this pull request
Nov 20, 2025
This test started failing with carbon-language#6405, but it wasn't caught by our PR testing or the merge queue as the test didn't _appear_ to be impacted by the change (I think). When run explicitly, as the post-commit actions do, it started failing because of the new dependency edge.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
This test started failing with #6405, but it wasn't caught by our PR testing or the merge queue as the test didn't _appear_ to be impacted by the change (I think). When run explicitly, as the post-commit actions do, it started failing because of the new dependency edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that the CC1 logic is directly extracted from Clang. There are probably some other places in the toolchain we should extract code like this where we're replicating and customizing logic from LLVM, but wanted to start here.