Move forward-decl-only code out to the handler of the forward decl node (Refactor Impl construction 3/7) #6467
+285
−190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than run the code for both decl and defn and make it conditional on not being a definition, put the code in the handler for the
Parse::ImplDeclIdnode, which is handled when there's no definition. This will help lead us to no longer needing to plumb aroundis_definitionlater.Make some naming consistent to call the reference to an
Implasimplinstead of sometimesimpl_info.This is part of #6420 which is being split up into a chain of smaller PRs. It is based on #6466.