Merged
Conversation
- regenerated the lockfile so we can take allegedly-semver-compatible updates to many packages - needed to unpin @types/qunit - needed to upgrade prettier-plugin-ember-template-tag across a major, which altered some formatting rules All the source changes here are either the prettier formatter changing or trivial typescript type tweaks.
Preview deployments |
This test was passing before by accident of timing. The code that would scroll to the earliest unread message was never running by the time the test looked. Now that code does run, and it does scroll to the first unread message, but the first unread mesage begins a few pixels down from actual zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the source changes here are either the prettier formatter changing or trivial typescript type tweaks.