-
Notifications
You must be signed in to change notification settings - Fork 12
Cs 10066 point the code ref of field spec to field #3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cs 10066 point the code ref of field spec to field #3855
Conversation
Host Test Results 1 files ± 0 1 suites ±0 2h 59m 30s ⏱️ + 1h 20m 20s For more details on these failures and errors, see this check. Results for commit 92f229d. ± Comparison against base commit 1e989a1. This pull request removes 213 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
56de20c to
4de5abf
Compare
| "readMe": null, | ||
| "ref": { | ||
| "module": "http://localhost:4201/catalog/fields/image/components/image-presentation", | ||
| "module": "../fields/image/components/image-presentation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didnt delete these component spec because it used in one of the CardListing
| /> | ||
| </template> | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why having two exports? I think there are consequences to this when for example you auto create-specs? If you dont want the default name I wud say just remove the default export imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the advice — I agree this can be confusing, as the current catalog-realm fields have evolved with different export patterns over time. Based on Burcu’s earlier guidance to favor default exports for consistency and flexible imports, I did a cleanup in catalog-realm so the related fields now follow the same export default pattern, giving us a single consistent format to follow going forward.
Preview deployments |
linear: https://linear.app/cardstack/issue/CS-10066/point-the-code-ref-of-field-spec-to-field
Demo:
