correct position of walkers. #648
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to generate training data with carla-simulator, and fetch image/pointcloud/objects information via carla-ros-bridge.
the problem is the message at
/carla/ego_vehicle/objectsor/carla/objectstopic with[derived_object_msgs](https://docs.ros.org/en/kinetic/api/derived_object_msgs/html/index-msg.html)/Objecttype.I found the
object_sensoris publishing objects like following behaviors:Object.pose.positionwill be the position on the ground(x-y plane), but it will be adjust to pivot point when publishingMarker.Object.pose.positionwill be the pivot point of bounding box, and there is no adjustment before publishingMarker.the reason, that I consider these behaviors are problematic, is the behaviors are not uniform, so I made this patch.
the reason, that I choose to modify the
walker.py, is that the position is intentionally adjusted when publishingMarkerinvehicle.py, so I think maintainers are proposing to publishobjectstopic with position on the ground, but not the pivot point.please help me to confirm this MR, thanks.
This change is