-
Notifications
You must be signed in to change notification settings - Fork 12
machine emulator to 0.19.0 rollups-node to 2.0.0-alpha.5 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine emulator to 0.19.0 rollups-node to 2.0.0-alpha.5 #259
Conversation
🦋 Changeset detectedLatest commit: 9029207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a1d9fed to
5c24de5
Compare
4166f80 to
167f5cb
Compare
167f5cb to
f50f6d9
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
c5068a8 to
35046b7
Compare
1ecf3a5 to
3a9dfb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Cartesi machine emulator and related tooling versions, updates build metadata handling, and configures snapshot persistence for the CLI.
- Add Turbo build task to generate
build.jsonand update.gitignore - Update Docker build scripts and bake files with new emulator & dependency versions
- Mount a persistent snapshots volume in the CLI’s Docker Compose setup
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/turbo.json | Added a Turbo task that outputs build.json |
| packages/sdk/package.json | Enhanced build script to write metadata to build.json |
| packages/sdk/docker-bake.hcl | Bumped base images and component versions (emulator, nodes) |
| packages/sdk/Dockerfile | Adjusted emulator download/install commands for v0.19.0 |
| packages/sdk/.gitignore | Ignored the generated build.json |
| apps/cli/wagmi.config.ts | Added inclusion patterns for deployments plugin |
| apps/cli/src/compose/docker-compose-node.yaml | Mounted snapshots volume for rollups-node |
| apps/cli/src/compose/default.env | Defined CARTESI_SNAPSHOTS_DIR environment variable |
| apps/cli/package.json | Updated @cartesi/rollups dependency to v2.0.0 |
| .github/workflows/devnet.yaml | Upgraded Foundry install version to v1.2.1 |
| .changeset/*.md | Created change files for each bumped package/version |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
.changeset/fluffy-trams-create.md:5
- The message refers to 'rollups-contracts', but the actual dependency updated is
@cartesi/rollups. Update this text to match the real package name for clarity.
bump rollups-contracts to 2.0.0
packages/sdk/Dockerfile:176
- The downloaded filename 'machine-emulator_${TARGETARCH}.deb' may not match the actual release asset, which typically includes the version and original 'cartesi-machine' prefix (e.g., 'cartesi-machine-v${VERSION}_${TARGETARCH}.deb'). Verify the asset name and URL to prevent download failures.
curl -fsSL https://github.com/cartesi/machine-emulator/releases/download/v${CARTESI_MACHINE_EMULATOR_VERSION}/machine-emulator_${TARGETARCH}.deb \
| env_file: | ||
| - ${CARTESI_BIN_PATH}/compose/default.env | ||
| volumes: | ||
| - snapshots:/var/lib/cartesi-rollups-node/snapshots |
Copilot
AI
Jun 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The snapshot directory path is hardcoded here but also defined in default.env. Consider referencing the CARTESI_SNAPSHOTS_DIR variable to keep the path consistent and configurable.
| - snapshots:/var/lib/cartesi-rollups-node/snapshots | |
| - snapshots:${CARTESI_SNAPSHOTS_DIR} |
this improves turbo cache handling
eeef922 to
9029207
Compare
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This pull request includes updates to dependencies, configuration files, and build processes across multiple packages in the repository. The most significant changes involve version bumps for key dependencies, updates to the build and deployment configurations, and the introduction of new features like snapshot management for
cartesi-rollups-node.Dependency Updates:
@cartesi/rollupsto version2.0.0inapps/cli/package.jsonandpnpm-lock.yamlto ensure compatibility with the latest release. [1] [2] [3] [4]foundryto version1.2.1in.changeset/all-rings-care.md,.changeset/open-loops-tap.md, and.github/workflows/devnet.yaml. [1] [2] [3]machine-emulatorto version0.19.0in.changeset/real-guests-peel.md,packages/sdk/Dockerfile, andpackages/sdk/docker-bake.hcl. [1] [2] [3]Build and Configuration Enhancements:
build.jsonoutput to the build process inpackages/sdk/package.jsonand introduced aturbo.jsonconfiguration file for task management. [1] [2]cartesi-sdkto a newer version of Debian inpackages/sdk/docker-bake.hcl.New Features:
cartesi-rollups-nodeinapps/cli/src/compose/default.envanddocker-compose-node.yaml. [1] [2]apps/cli/wagmi.config.tsby adding support for additional contract patterns.Minor Updates:
build.jsonto.gitignoreinpackages/sdk.