Skip to content

Conversation

@endersonmaia
Copy link
Contributor

@endersonmaia endersonmaia commented May 5, 2025

This pull request includes updates to dependencies, configuration files, and build processes across multiple packages in the repository. The most significant changes involve version bumps for key dependencies, updates to the build and deployment configurations, and the introduction of new features like snapshot management for cartesi-rollups-node.

Dependency Updates:

  • Updated @cartesi/rollups to version 2.0.0 in apps/cli/package.json and pnpm-lock.yaml to ensure compatibility with the latest release. [1] [2] [3] [4]
  • Bumped foundry to version 1.2.1 in .changeset/all-rings-care.md, .changeset/open-loops-tap.md, and .github/workflows/devnet.yaml. [1] [2] [3]
  • Updated machine-emulator to version 0.19.0 in .changeset/real-guests-peel.md, packages/sdk/Dockerfile, and packages/sdk/docker-bake.hcl. [1] [2] [3]

Build and Configuration Enhancements:

  • Added build.json output to the build process in packages/sdk/package.json and introduced a turbo.json configuration file for task management. [1] [2]
  • Updated the base Docker image for cartesi-sdk to a newer version of Debian in packages/sdk/docker-bake.hcl.

New Features:

  • Introduced snapshot directory management for cartesi-rollups-node in apps/cli/src/compose/default.env and docker-compose-node.yaml. [1] [2]
  • Enhanced deployment configuration in apps/cli/wagmi.config.ts by adding support for additional contract patterns.

Minor Updates:

  • Added build.json to .gitignore in packages/sdk.

@endersonmaia endersonmaia self-assigned this May 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 9029207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cartesi/devnet Patch
@cartesi/cli Patch
@cartesi/sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endersonmaia endersonmaia force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch from a1d9fed to 5c24de5 Compare May 5, 2025 14:32
@tuler tuler changed the title Chore/bump machine emulator to 0.19.0 alpha4 Bump machine emulator to 0.19.0 alpha4 May 19, 2025
@endersonmaia endersonmaia force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch 2 times, most recently from 4166f80 to 167f5cb Compare May 22, 2025 18:06
@endersonmaia endersonmaia force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch from 167f5cb to f50f6d9 Compare May 30, 2025 16:38
@tuler tuler changed the title Bump machine emulator to 0.19.0 alpha4 Bump machine emulator to 0.19.0 May 30, 2025
@tuler tuler changed the title Bump machine emulator to 0.19.0 machine emulator to 0.19.0 May 30, 2025
@socket-security
Copy link

socket-security bot commented Jun 2, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​cartesi/​rollups@​2.0.0-rc.17 ⏵ 2.0.04910091 +297100

View full report

@tuler tuler force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch from c5068a8 to 35046b7 Compare June 6, 2025 02:30
@endersonmaia endersonmaia force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch 3 times, most recently from 1ecf3a5 to 3a9dfb1 Compare June 9, 2025 19:51
@endersonmaia endersonmaia requested review from Copilot and tuler June 9, 2025 20:14
@endersonmaia endersonmaia marked this pull request as ready for review June 9, 2025 20:15
@endersonmaia endersonmaia changed the title machine emulator to 0.19.0 machine emulator to 0.19.0 rollups-node to 2.0.0-alpha.5 Jun 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Cartesi machine emulator and related tooling versions, updates build metadata handling, and configures snapshot persistence for the CLI.

  • Add Turbo build task to generate build.json and update .gitignore
  • Update Docker build scripts and bake files with new emulator & dependency versions
  • Mount a persistent snapshots volume in the CLI’s Docker Compose setup

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/sdk/turbo.json Added a Turbo task that outputs build.json
packages/sdk/package.json Enhanced build script to write metadata to build.json
packages/sdk/docker-bake.hcl Bumped base images and component versions (emulator, nodes)
packages/sdk/Dockerfile Adjusted emulator download/install commands for v0.19.0
packages/sdk/.gitignore Ignored the generated build.json
apps/cli/wagmi.config.ts Added inclusion patterns for deployments plugin
apps/cli/src/compose/docker-compose-node.yaml Mounted snapshots volume for rollups-node
apps/cli/src/compose/default.env Defined CARTESI_SNAPSHOTS_DIR environment variable
apps/cli/package.json Updated @cartesi/rollups dependency to v2.0.0
.github/workflows/devnet.yaml Upgraded Foundry install version to v1.2.1
.changeset/*.md Created change files for each bumped package/version
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

.changeset/fluffy-trams-create.md:5

  • The message refers to 'rollups-contracts', but the actual dependency updated is @cartesi/rollups. Update this text to match the real package name for clarity.
bump rollups-contracts to 2.0.0

packages/sdk/Dockerfile:176

  • The downloaded filename 'machine-emulator_${TARGETARCH}.deb' may not match the actual release asset, which typically includes the version and original 'cartesi-machine' prefix (e.g., 'cartesi-machine-v${VERSION}_${TARGETARCH}.deb'). Verify the asset name and URL to prevent download failures.
curl -fsSL https://github.com/cartesi/machine-emulator/releases/download/v${CARTESI_MACHINE_EMULATOR_VERSION}/machine-emulator_${TARGETARCH}.deb \

env_file:
- ${CARTESI_BIN_PATH}/compose/default.env
volumes:
- snapshots:/var/lib/cartesi-rollups-node/snapshots
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The snapshot directory path is hardcoded here but also defined in default.env. Consider referencing the CARTESI_SNAPSHOTS_DIR variable to keep the path consistent and configurable.

Suggested change
- snapshots:/var/lib/cartesi-rollups-node/snapshots
- snapshots:${CARTESI_SNAPSHOTS_DIR}

Copilot uses AI. Check for mistakes.
@endersonmaia endersonmaia force-pushed the chore/bump-machine-emulator-to-0.19.0-alpha4 branch from eeef922 to 9029207 Compare June 9, 2025 20:17
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 26.38% 295 / 1118
🔵 Statements 26.33% 300 / 1139
🔵 Functions 25.5% 51 / 200
🔵 Branches 23.82% 117 / 491
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/wagmi.config.ts 0% 0% 0% 0% 6-62
Generated in workflow #547 for commit 9029207 by the Vitest Coverage Report Action

@endersonmaia endersonmaia merged commit 2faaa26 into prerelease/v2-alpha Jun 9, 2025
9 checks passed
@endersonmaia endersonmaia deleted the chore/bump-machine-emulator-to-0.19.0-alpha4 branch June 9, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants