Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Sep 17, 2025

Update all dependencies from workspace and CLI

@tuler tuler requested a review from endersonmaia September 17, 2025 18:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 15be5ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tuler tuler changed the base branch from main to prerelease/v2-alpha September 17, 2025 18:22
@endersonmaia
Copy link
Contributor

Shouldn't the CI jog to run apps/cli tests be triggered?

If so, pleas adjust the ci so it runs the tests.

@tuler
Copy link
Member Author

tuler commented Sep 17, 2025

Shouldn't the CI jog to run apps/cli tests be triggered?

The cli workflow should run.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 25.08% 279 / 1112
🔵 Statements 25.02% 284 / 1135
🔵 Functions 25.77% 50 / 194
🔵 Branches 21.62% 112 / 518
File CoverageNo changed files found.
Generated in workflow #658 for commit 15be5ad by the Vitest Coverage Report Action

@tuler
Copy link
Member Author

tuler commented Sep 17, 2025

If so, pleas adjust the ci so it runs the tests.

Did a small change to .github/workflows/cli.yaml, and the workflow was now triggered.
I don't know though if the trigger was the change of the .github/workflows/cli.yaml file itself, which is included in the paths of the CI, or if the CI definitely needs quotes in paths, which is the change I made.

@tuler tuler force-pushed the feature/dependencies branch from ee795b0 to 15be5ad Compare September 17, 2025 20:17
@tuler tuler merged commit 20e1630 into prerelease/v2-alpha Sep 17, 2025
10 checks passed
@tuler tuler deleted the feature/dependencies branch September 17, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants