Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Jan 6, 2026

This changes the PR #375 in a few ways.

  • it keeps the type system created for the compose structure.
  • it creates a function to merge compose structures following the rules at https://docs.docker.com/reference/compose-file/merge/ (this was mostly AI generated).
  • it changes from a class based generator to a simple concatenation of compose structures using the function above

I think this feels cleaner.
I did a basic test with basic services and explorer service. (account abstraction infrastructure is currently broken).

@tuler tuler requested a review from endersonmaia January 6, 2026 17:12
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

⚠️ No Changeset found

Latest commit: 2c8fbc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 18.91% 279 / 1475
🔵 Statements 18.88% 284 / 1504
🔵 Functions 19.84% 50 / 252
🔵 Branches 13.65% 112 / 820
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/commands/logs.ts 0% 0% 0% 0% 5-48
apps/cli/src/commands/status.ts 0% 0% 0% 0% 7-57
apps/cli/src/compose/anvil.ts 0% 0% 0% 0% 10-63
apps/cli/src/compose/builder.ts 0% 0% 0% 0% 25-653
apps/cli/src/compose/bundler.ts 0% 0% 0% 0% 8-94
apps/cli/src/compose/common.ts 0% 100% 100% 0% 3-9
apps/cli/src/compose/database.ts 0% 0% 0% 0% 10-28
apps/cli/src/compose/explorer.ts 0% 0% 0% 0% 14-158
apps/cli/src/compose/node.ts 0% 0% 0% 0% 22-118
apps/cli/src/compose/passkey.ts 0% 0% 0% 0% 9-61
apps/cli/src/compose/paymaster.ts 0% 0% 0% 0% 8-63
apps/cli/src/compose/proxy.ts 0% 0% 0% 0% 9-38
apps/cli/src/exec/rollups.ts 0% 0% 0% 0% 51-547
Generated in workflow #711 for commit 2c8fbc6 by the Vitest Coverage Report Action

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing, I can't CTRL + C when I pick (l) View logs.

But the YAML part works as expected.

Tests were removed, I think the concat() functions deserves testing.

@tuler
Copy link
Member Author

tuler commented Jan 6, 2026

While testing, I can't CTRL + C when I pick (l) View logs.

Looks unrelated. Happens only on this branch?

@endersonmaia
Copy link
Contributor

While testing, I can't CTRL + C when I pick (l) View logs.

Looks unrelated. Happens only on this branch?

Didn't happen at feature/ts-compose-builder branch.

@tuler
Copy link
Member Author

tuler commented Jan 6, 2026

Didn't happen at feature/ts-compose-builder branch.

So we need to investigate this deeper

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't block for lack of unit tests for now.

@endersonmaia endersonmaia merged commit 1592e02 into feature/ts-compose-builder Jan 6, 2026
4 checks passed
@endersonmaia endersonmaia deleted the feature/ts-compose branch January 6, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants