-
Notifications
You must be signed in to change notification settings - Fork 12
Changes to migrate compose from YAML to TS #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing, I can't CTRL + C when I pick (l) View logs.
But the YAML part works as expected.
Tests were removed, I think the concat() functions deserves testing.
Looks unrelated. Happens only on this branch? |
Didn't happen at |
So we need to investigate this deeper |
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't block for lack of unit tests for now.
This changes the PR #375 in a few ways.
I think this feels cleaner.
I did a basic test with basic services and explorer service. (account abstraction infrastructure is currently broken).