refactor(prt-contracts): merge (non)rootTournament into Tournament #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenctw
force-pushed
the
feature/prt-tournament-simplification
branch
2 times, most recently
from
e4fd7b5 to
f734050
Compare
Collaborator
|
Looking great! Once commits are squashed, I will approve the PR. |
stephenctw
force-pushed
the
feature/prt-tournament-simplification
branch
from
fa741b5 to
597c789
Compare
guidanoli
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have a much simpler abstract structur - only (non)LeafTournament left. There's no more dimond inheritance and circular depedency. I think this is a great start, and we can discuss whether we should go further on this simplification process.