Fix for #614 #616
Merged
Fix for #614 #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 83.66% 84.15% +0.48%
==========================================
Files 83 83
Lines 4799 4802 +3
Branches 604 604
==========================================
+ Hits 4015 4041 +26
+ Misses 570 550 -20
+ Partials 214 211 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbogaardt
requested review from
jbogaardt
and removed request for
kennethshsu
jbogaardt
approved these changes
Nov 4, 2025
jbogaardt
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top half of screenshot shows issue from #614 being resolved. Bottom half of screenshot shows a display issue with off-1/1 origin dates.
Here is same snippet, run in the current master. Note that the origin dates issue was already there.
