Skip to content

feat!: merge subject.source into subject.id #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidB wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: merge subject.source into subject.id #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cloudevents-binding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ Content-Length: nnnn
"task": "my-task",
"uri": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123"
"pipelineRun": {
"id": "/somewherelse/pipelinerun-123",
"source": "/staging/jenkins/"
"id": "/staging/jenkins/somewherelse/pipelinerun-123"
}
}
}
Expand Down
1 change: 0 additions & 1 deletion conformance/artifact_deleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
},
"subject": {
"id": "pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c",
"source": "/event/source/123",
"content": {
"user": "mybot-myapp"
}
Expand Down
1 change: 0 additions & 1 deletion conformance/artifact_downloaded.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
},
"subject": {
"id": "pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c",
"source": "/event/source/123",
"content": {
"user": "mybot-myapp"
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/artifact_packaged.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c",
"source": "/event/source/123",
"content": {
"change": {
"id": "myChange123",
"source": "my-git.example/an-org/a-repo"
"id": "my-git.example/an-org/a-repo/myChange123"
},
"sbom": {
"uri": "https://sbom.repo/myorg/234fd47e07d1004f0aed9c.sbom"
Expand Down
1 change: 0 additions & 1 deletion conformance/artifact_published.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c",
"source": "/event/source/123",
"content": {
"sbom": {
"uri": "https://sbom.repo/myorg/234fd47e07d1004f0aed9c.sbom"
Expand Down
1 change: 0 additions & 1 deletion conformance/artifact_signed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c",
"source": "/event/source/123",
"content": {
"signature": "MEYCIQCBT8U5ypDXWCjlNKfzTV4KH516/SK13NZSh8znnSMNkQIhAJ3XiQlc9PM1KyjITcZXHotdMB+J3NGua5T/yshmiPmp"
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/branch_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/branch_deleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
1 change: 0 additions & 1 deletion conformance/build_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"artifactId": "pkg:oci/myapp@sha256%3A0b31b1c02ff458ad9b7b81cbdf8f028bd54699fa151f221d1e8de6817db93427"
}
Expand Down
1 change: 0 additions & 1 deletion conformance/build_queued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {}
}
}
1 change: 0 additions & 1 deletion conformance/build_started.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {}
}
}
4 changes: 1 addition & 3 deletions conformance/change_abandoned.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/change_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,10 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"description": "This PR address a bug from a recent PR",
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/change_merged.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/change_reviewed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions conformance/change_updated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"repository": {
"id": "TestRepo/TestOrg",
"source": "https://example.org"
"id": "https://example.org/TestRepo/TestOrg"
}
}
}
Expand Down
1 change: 0 additions & 1 deletion conformance/environment_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "testEnv",
"uri": "https://example.org/testEnv"
Expand Down
1 change: 0 additions & 1 deletion conformance/environment_deleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "testEnv"
}
Expand Down
1 change: 0 additions & 1 deletion conformance/environment_modified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "testEnv",
"uri": "https://example.org/testEnv"
Expand Down
7 changes: 2 additions & 5 deletions conformance/incident_detected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,13 @@
},
"subject": {
"id": "incident-123",
"source": "/monitoring/prod1",
"content": {
"description": "Response time above threshold of 100ms",
"environment": {
"id": "prod1",
"source": "/iaas/geo1"
"id": "/iaas/geo1/prod1"
},
"service": {
"id": "myApp",
"source": "/clusterA/namespaceB"
"id": "/clusterA/namespaceB/myApp"
},
"artifactId": "pkg:oci/myapp@sha256%3A0b31b1c02ff458ad9b7b81cbdf8f028bd54699fa151f221d1e8de6817db93427"
}
Expand Down
7 changes: 2 additions & 5 deletions conformance/incident_reported.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,13 @@
},
"subject": {
"id": "incident-123",
"source": "/monitoring/prod1",
"content": {
"description": "Response time above threshold of 100ms",
"environment": {
"id": "prod1",
"source": "/iaas/geo1"
"id": "/iaas/geo1/prod1"
},
"service": {
"id": "myApp",
"source": "/clusterA/namespaceB"
"id": "/clusterA/namespaceB/myApp"
},
"artifactId": "pkg:oci/myapp@sha256%3A0b31b1c02ff458ad9b7b81cbdf8f028bd54699fa151f221d1e8de6817db93427",
"ticketURI": "https://my-issues.example/incidents/ticket-345"
Expand Down
7 changes: 2 additions & 5 deletions conformance/incident_resolved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,13 @@
},
"subject": {
"id": "incident-123",
"source": "/monitoring/prod1",
"content": {
"description": "Response time restored below 100ms",
"environment": {
"id": "prod1",
"source": "/iaas/geo1"
"id": "/iaas/geo1/prod1"
},
"service": {
"id": "myApp",
"source": "/clusterA/namespaceB"
"id": "/clusterA/namespaceB/myApp"
},
"artifactId": "pkg:oci/myapp@sha256%3A0b31b1c02ff458ad9b7b81cbdf8f028bd54699fa151f221d1e8de6817db93439"
}
Expand Down
1 change: 0 additions & 1 deletion conformance/pipelinerun_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"pipelineName": "myPipeline",
"uri": "https://www.example.com/mySubject123",
Expand Down
1 change: 0 additions & 1 deletion conformance/pipelinerun_queued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"pipelineName": "myPipeline",
"uri": "https://www.example.com/mySubject123"
Expand Down
1 change: 0 additions & 1 deletion conformance/pipelinerun_started.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"pipelineName": "myPipeline",
"uri": "https://www.example.com/mySubject123"
Expand Down
1 change: 0 additions & 1 deletion conformance/repository_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "TestRepo",
"owner": "TestOrg",
Expand Down
1 change: 0 additions & 1 deletion conformance/repository_deleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "TestRepo",
"owner": "TestOrg",
Expand Down
1 change: 0 additions & 1 deletion conformance/repository_modified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"name": "TestRepo",
"owner": "TestOrg",
Expand Down
1 change: 0 additions & 1 deletion conformance/service_deployed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "test123"
Expand Down
1 change: 0 additions & 1 deletion conformance/service_published.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "test123"
Expand Down
1 change: 0 additions & 1 deletion conformance/service_removed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "test123"
Expand Down
1 change: 0 additions & 1 deletion conformance/service_rolledback.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "test123"
Expand Down
1 change: 0 additions & 1 deletion conformance/service_upgraded.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "test123"
Expand Down
1 change: 0 additions & 1 deletion conformance/taskrun_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"taskName": "myTask",
"uri": "https://www.example.com/mySubject123",
Expand Down
1 change: 0 additions & 1 deletion conformance/taskrun_started.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
},
"subject": {
"id": "mySubject123",
"source": "/event/source/123",
"content": {
"taskName": "myTask",
"uri": "https://www.example.com/mySubject123",
Expand Down
4 changes: 1 addition & 3 deletions conformance/testcaserun_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,10 @@
},
"subject": {
"id": "myTestCaseRun123",
"source": "/event/source/123",
"content": {
"outcome": "success",
"environment": {
"id": "dev",
"source": "testkube-dev-123"
"id": "/testkube-dev-123/dev"
},
"testCase": {
"id": "92834723894",
Expand Down
4 changes: 1 addition & 3 deletions conformance/testcaserun_queued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@
},
"subject": {
"id": "myTestCaseRun123",
"source": "/event/source/123",
"content": {
"environment": {
"id": "dev",
"source": "testkube-dev-123"
"id": "/testkube-dev-123/dev"
},
"testCase": {
"id": "92834723894",
Expand Down
Loading