Prevent sending of SMS that costs more billable units than the remaining daily/annual limit#2590
Merged
Prevent sending of SMS that costs more billable units than the remaining daily/annual limit#2590
Conversation
…ing daily/annual limit
🧪 Review environmenthttps://xxyspzlzr6iuz57hosb5fowmnm0kejit.lambda-url.ca-central-1.on.aws/ |
jzbahrai
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
For one-off sends (user clicks "no, send yourself this message") that would result in the user exceeding their daily/annual limit, the send buttons should be hidden ("Yes, add recipients", and "No, send yourself this message").
This worked for
FF_USE_BILLABLE_UNITS = falsebut did not work forFF_USE_BILLABLE_UNITS = true. This PR fixes that.Test instructions | Instructions pour tester la modification
Repeat the test, setting the annual limit to 2.