Add Lit Protocol PKP Wallet Support#140
Open
DustilDawn wants to merge 1 commit intoceramicnetwork:mainfrom
Open
Add Lit Protocol PKP Wallet Support#140DustilDawn wants to merge 1 commit intoceramicnetwork:mainfrom
DustilDawn wants to merge 1 commit intoceramicnetwork:mainfrom
Conversation
Hey there, so I've been working on Lit Protocol during this hackathon and made it work with PKP! This will be a great shared account feature for the ecosystem! https://github.com/DustilDawn/orbis-sdk/blob/de27fe2a4d2a312c4211c90bfda87c423fe2c174/index.js#L6
oed
reviewed
Jan 19, 2023
Collaborator
oed
left a comment
There was a problem hiding this comment.
Not sure why this would be needed. The safeSend function should already take care of using sendAsync: https://github.com/ceramicnetwork/js-did/blob/main/packages/pkh-ethereum/src/utils.ts#L17
If there is an issue, then the safeSend function should be modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, so I've been working on Lit Protocol during this hackathon and made it work with PKP! This will be a great shared account feature for the ecosystem!
https://github.com/DustilDawn/orbis-sdk/blob/de27fe2a4d2a312c4211c90bfda87c423fe2c174/index.js#L6
PKP Wallet Support - #[Issue]
Description
Include a summary of the change and which issue it addresses in the title of the PR.
Include relevant motivation, context, brief description and impact of the change(s). List follow-up tasks here.
How Has This Been Tested?
Describe the tests that you ran to verify your changes. Provide instructions for reproduction.
Definition of Done
Before submitting this PR, please make sure:
References:
Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.