MFMailComposeViewController by baruma · Pull Request #91 · cforlando/PetAdoption-iOS

baruma · 2018-04-17T01:19:06Z

Users now able to write to shelters without exiting app using MFMailComposeVC.

Added MFMailComposeViewController. Users are now able to send emails to shelters without exiting app.

WERUreo

Not bad for your first commit! If you have any questions about the comments I've left, just ask. :)

WERUreo · 2018-04-17T01:42:22Z

+
+    func configureMailController() -> MFMailComposeViewController {
+        let mailComposerVC = MFMailComposeViewController()
+        let emailString = pet?.contact.email


You might want to do an if check on the email to make sure it isn't an empty string before trying to compose an email. I've noticed from the API responses that the email field is not always filled out.

In fact, that being the case, you might also want to make the return type optional, so that you can check for it later on when you are about to try presenting the view controller.

WERUreo · 2018-04-17T01:46:58Z

+        let sectionNumber = indexPath.section
+        let rowNumber = indexPath.row
+        if sectionNumber == 3 && rowNumber == 1 {
+            let mailComposeViewController = configureMailController()


If the return type for configureMailController() is optional like I suggested above, you can wrap all of this code in an if let and only try to present the controller if there is actually an email address.

WERUreo · 2018-04-17T01:48:20Z

@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>


Make sure that this file isn't getting removed in your commit. The apikey.plist.example needs to remain in the repo for others to use if they want to develop for the project.

Got it. I might need help doing this later, but I'll reach out to you or John in regards to this. Sorry about the hiatus by the way, looking to fix up the email feature this month.

WERUreo · 2018-04-17T01:54:01Z

+
+    ////////////////////////////////////////////////////////////
+    // MARK: - UITableViewDataSource
+    ////////////////////////////////////////////////////////////


This MARK section isn't needed, because you're already under the existing MARK section for the UITableViewDataSource. Just push the beginning of the function underneath that comment line just above where you added this.

Got it, just removed it.

WERUreo · 2018-04-17T02:03:25Z

+
+        let sectionNumber = indexPath.section
+        let rowNumber = indexPath.row
+        if sectionNumber == 3 && rowNumber == 1 {


I get what you're doing here, and this works as the table view is currently set up, but this is probably not the best approach. You probably want to avoid using "magic numbers" like this. At the VERY least, I would define constants near the top of the file to make it easier to change these values if the need ever arose, but I actually have a more robust solution for this if you're interested in taking a look.

I'd be down to look at the solution you have currently since I'm having issues figuring out how to go about selecting the email row specifically. I only did it this way for the time being since all the pets have the same number of cells but of course that's subject to change in the future.

OK, I'll push up a separate pull request with what I came up with and link it to you on Slack. I'll be happy to go over with you also if you want.

For now, let's just leave this in here like this, only because I don't want you to have to wait on me. If you could, though, could you add a TODO comment here? Something like:

// TODO: Refactor this approach to avoid using magic numbers

or something to that effect.

WERUreo

There's also still a couple of things from my first review that need to be addressed, including putting the apikey.plist.example back, for one.

WERUreo · 2018-04-17T23:44:42Z

 				INFOPLIST_FILE = "PetAdoption-iOS/Info.plist";
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
-				PRODUCT_BUNDLE_IDENTIFIER = com.cfo.petadoption;
+				PRODUCT_BUNDLE_IDENTIFIER = com.lhaquebaruma.petadoption;


Looks like you forgot to set the bundle identifier back again heh

I'll be sure to set it to cfo before I push the updates to git

WERUreo · 2018-04-17T23:46:18Z

+//            }
+//        }
+//    }
+//


Typically I would say not to leave commented out code like this in. It's fine for now since I know you're working on the phone number issue next.

WERUreo · 2018-04-17T23:54:07Z

+        if sectionNumber == 3 && rowNumber == 1 {
+            let mailComposeViewController = configureMailController()
+            if MFMailComposeViewController.canSendMail() {
+                self.present((mailComposeViewController)!, animated: true, completion: nil)


The idea with making the return from configureMailController() be optional was that you could use an if let and avoid force unwrapping it like you're doing. Something more like

if let mailComposeViewController = configureMailController() { if MFMailComposeViewController.canSendMail() { self.present(mailComposeViewController, animated: true, completion: nil) } else { displayEmailError() } }

It's been a while since I looked over at this! I actually meddled with the solution you gave and it works except that all the cells available become active and end up triggering the mailComposeVC. How should I go about preventing that?

Do you mean implementing the above snippet of code? I just made that change locally (it's not that different than what you currently had there) and it seems to only be trying to compose mail on the mail row.

WERUreo · 2018-04-17T23:54:32Z

+//        If the return type for configureMailController() is optional like I suggested above,
+//        you can wrap all of this code in an if let and only try to
+//        present the controller if there is actually an email address.
+//


These look like the comments I made in my last review hehe... You can go ahead and remove these.

Removed it!

WERUreo · 2018-04-17T23:57:02Z

+
+        let sectionNumber = indexPath.section
+        let rowNumber = indexPath.row
+        if sectionNumber == 3 && rowNumber == 1 {


For now, let's just leave this in here like this, only because I don't want you to have to wait on me. If you could, though, could you add a TODO comment here? Something like:

// TODO: Refactor this approach to avoid using magic numbers

or something to that effect.

baruma added 3 commits April 16, 2018 18:34

Created MFMailComposerVC

d16171d

Merge remote-tracking branch 'refs/remotes/origin/develop' into develop

e34fe87

Added MFMailComposeViewController. Users are now able to send emails to shelters without exiting app.

MailComposeVC added. Can email shelters w/out leaving app

74e9ed4

baruma requested a review from WERUreo April 17, 2018 01:19

WERUreo requested changes Apr 17, 2018

View reviewed changes

adjusted email logic to block empty email cells

ab46cfa

WERUreo requested changes Apr 17, 2018

View reviewed changes

WERUreo added the in review label May 1, 2018

Conversation

baruma commented Apr 17, 2018

Uh oh!

WERUreo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WERUreo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

baruma Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

baruma Jun 5, 2018 •

edited

Loading