Development by Yoshae101 · Pull Request #116 · cfrantzidis/DungeonExplorer

Yoshae101 · 2025-03-13T10:00:34Z

code for review

submission for review

VizzWizz · 2025-03-13T10:17:49Z

Game.cs

+                "As you push open the rustic wooden doors, the air thickens. The Orcs throne glistens from the dying flame in the centre of the floor. " +
+                "The rugged red carpet underneath your feet tears as you tread into the room, the breeze from the hall follows you in giving life back to the now roaring fire. " +
+                "The room, now engulfed in a flickering light, uncovers the throne room from its dark veil ... you decide to explore the room."
+            );


Very nice that the player can select their own name if they want

VizzWizz · 2025-03-13T10:20:52Z

Game.cs

+            while (currentRoom.HasRemainingItems())
+            {
+                Console.WriteLine("Where would you like to check out? Choose an option by number:");
+                currentRoom.ShowLocations();
+
+                int choice = GetUserChoice();
+                // Valid index check (user enters 1-4)
+                if (choice < 1 || choice > currentRoom.Locations.Count)
+                {
+                    Console.WriteLine("Invalid option. Please choose a valid number.");
+                    continue;
+                }
+
+                // Pick up the item (if available) from the chosen location.
+                string itemFound = currentRoom.PickUpItemFromLocation(choice - 1);
+                if (itemFound != null)
+                {
+                    player.PickUpItem(itemFound);
+                }
+                Console.WriteLine("\nPlayer Status:");
+                Console.WriteLine(player.GetStatus());
+                Console.WriteLine();
+            }


Good error checking

VizzWizz · 2025-03-13T10:23:29Z

Game.cs

+            int option;
+            if (int.TryParse(input, out option))
            {
-                // Code your playing logic here
+                return option;
            }
+            return -1;


int.TryParse's function doesnt need an if statement, it will either return 0 or the number inputted for that variable
Try changing this whole block to just int.TryParse(input, out int option)

VizzWizz · 2025-03-13T10:24:59Z

Location.cs

Good use of OOP to further abstract the location of the rooms

VizzWizz

Code Review
William Viziteu - 29171215

Code works well and runs without crashing, with good error handling
Readability is difficult at times, try also to use XML comments instead
Good use of basic OOP techniques
Implemented a story to the game

bofagit

Overall, you have successfully implemented the requirements of the brief to your game. The code runs well and is quite efficient. You have made good use of methods and encapsulation throughout your code.

I would recommend adding more comments to your Player class to further explain what your code does, as well as expanding on previous comments.
I would also recommend changing your naming conventions as I mentioned in the Player class; PascalCase for public members ect.

Nice work.

bofagit · 2025-03-13T12:16:16Z

Location.cs

+    public class Location
+    {
+        public string Name { get; private set; }
+        public string Description { get; private set; }
+        public string Item { get; private set; }
+
+        public Location(string name, string description, string item)
+        {
+            Name = name;
+            Description = description;
+            Item = item;
+        }


Good use of encapsulation in the class.

bofagit · 2025-03-13T12:19:09Z

Game.cs

+            currentRoom = new Room(
+                "As you push open the rustic wooden doors, the air thickens. The Orcs throne glistens from the dying flame in the centre of the floor. " +
+                "The rugged red carpet underneath your feet tears as you tread into the room, the breeze from the hall follows you in giving life back to the now roaring fire. " +
+                "The room, now engulfed in a flickering light, uncovers the throne room from its dark veil ... you decide to explore the room."
+            );


Detailed description of the room is good. You could potentially add a method to the Room.cs file to pick from a random selection of descriptions to create a randomly generated start.

bofagit · 2025-03-13T12:28:26Z

Room.cs

+        public string PickUpItemFromLocation(int index)
+        {
+            Location loc = Locations[index];
+            if (loc.Item != null)
+            {
+                Console.WriteLine($"\nYou travel to the {loc.Name} and find a {loc.Item}!");
+                return loc.PickUpItem();
+            }
+            else
+            {
+                Console.WriteLine($"\nYou travel to the {loc.Name} but find nothing of value.");
+                return null;
+            }
+        }


Good use of the list of items to check if there are items or not in the area.

bofagit · 2025-03-13T12:29:31Z

Player.cs

    public class Player
    {
-        public string Name { get; private set; }
-        public int Health { get; private set; }
-        private List<string> inventory = new List<string>();
+        private string name;
+        private int health;
+        private List<string> inventory;


Great use of encapsulation here to get and set the values of the player.

bofagit · 2025-03-13T12:32:18Z

Player.cs

    public class Player
    {
-        public string Name { get; private set; }
-        public int Health { get; private set; }
-        private List<string> inventory = new List<string>();
+        private string name;
+        private int health;
+        private List<string> inventory;


Your naming conventions here are a little inconsistent in some of your classes, maybe try PascalCase for public members, and lowercase for private.

Tasha53

Overall your code is very well written and commented making it easy to follow. The game also runs smoothly and has some good features, making it fun to play. A few additions which may give your game more depth would be to include monsters in some of the locations for the player to fight and maybe implement a difficulty selector, so the player can choose to play on easy, medium or hard mode - the difficulty could determine the abundance and strength of the monsters.

Tasha53 · 2025-03-13T13:19:05Z

Game.cs

+            Console.WriteLine("\nGame started...\n");
+
+            // Display the room's description.
+            Console.WriteLine(currentRoom.GetDescription());


good use of a function for the description of the room - keeps the code tidy

Tasha53 · 2025-03-13T13:21:06Z

Game.cs

+            // Show travel options until all items have been collected.
+            while (currentRoom.HasRemainingItems())
+            {
+                Console.WriteLine("Where would you like to check out? Choose an option by number:");


I like how the user can choose different locations to explore - adds depth to the game and gives each round some uniqueness.

Tasha53 · 2025-03-13T13:22:23Z

Room.cs

+            // Create four locations with specific items.
+            Locations = new List<Location>
+            {
+                new Location("Warped Wooden Table", "A creaky wooden table, scarred by time.", "Healing Chalice"),


Nice detailed descriptions of different locations

Tasha53 · 2025-03-13T13:27:28Z

Room.cs

+        }
+
+        // When a location is visited, pick up the item if available.
+        public string PickUpItemFromLocation(int index)


I like the idea that the player has to collect all of the items, however to give the game more depth you could have some locations generate with a monster that the player can battle. This would also give items such as health potions some functionality as the player could use the items to heal after battles

Tasha53 · 2025-03-13T13:29:06Z

Game.cs

+                // Valid index check (user enters 1-4)
+                if (choice < 1 || choice > currentRoom.Locations.Count)
+                {
+                    Console.WriteLine("Invalid option. Please choose a valid number.");


Good error checking to ensure the user gives a valid input

Final Commit

Yoshae101 added 2 commits March 13, 2025 09:57

Development

5d965f4

dungeon explorer foundation

5c050cd

submission for review

VizzWizz reviewed Mar 13, 2025

View reviewed changes

Location.cs

Copy link

VizzWizz Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of OOP to further abstract the location of the rooms

VizzWizz reviewed Mar 13, 2025

View reviewed changes

bofagit reviewed Mar 13, 2025

View reviewed changes

Tasha53 reviewed Mar 13, 2025

View reviewed changes

Assignment 2 Commit

aa40076

Final Commit

Conversation

Yoshae101 commented Mar 13, 2025

Uh oh!

VizzWizz Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VizzWizz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bofagit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tasha53 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VizzWizz Mar 13, 2025 •

edited

Loading

VizzWizz left a comment •

edited

Loading