Skip to content

docs: mention table width is required in v2 upgrade guide #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmwangx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: mention table width is required in v2 upgrade guide #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADE_GUIDE_V2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,8 @@ sw := stopwatch.New(stopwatch.WithInterval(500 * time.Millisecond))

The table already had `SetWidth`/`SetHeight`/`Width()`/`Height()` in v1, but internally these now use viewport getter/setters.

An explicit width is now required or the table body may be blank. You can pass the `WithWidth()` option to `New()` to set it.

### Textarea

#### KeyMap
Expand Down