Skip to content

Conversation

@jessp01
Copy link

@jessp01 jessp01 commented Feb 25, 2025

Implement term search inside markdown:

  • The search is case-insensitive
  • Only the first 3 matches are displayed but the total count is noted as well
  • Search term is highlighted in the results

See screencast for illustration purposes

Additional changes:

  • README: reference v2 in badges and links for Go docs and Go Report Card
  • Fix some issues reported by golint and gocritic

- Reference v2 in README badges
- Fix some issues reported by `golint` and `gocritic`
@jessp01 jessp01 requested a review from a team as a code owner February 25, 2025 01:56
@jessp01 jessp01 requested review from bashbunni and removed request for a team February 25, 2025 01:56
@jessp01 jessp01 marked this pull request as draft February 25, 2025 01:57
- Reset matches when search term is reset/edited
- Reset matches when search term is reset/edited
- Truncate match line if total line length > availableScreenWidth
- display total number of matches found in file
@jessp01 jessp01 marked this pull request as ready for review February 25, 2025 19:34
@jessp01 jessp01 changed the title Search term inside README files Search term inside markdown files Feb 25, 2025
@jessp01
Copy link
Author

jessp01 commented Apr 15, 2025

Hi Team,

Any thoughts on this? The branch now has conflicts as it's been two months but, I can resolve these if you're interested in merging...

Cheers,

gustavosbarreto pushed a commit to drera-labs/glow that referenced this pull request Jun 9, 2025
…rmbracelet#705)

Bumps [github.com/alecthomas/kong](https://github.com/alecthomas/kong) from 1.2.1 to 1.4.0.
- [Commits](alecthomas/kong@v1.2.1...v1.4.0)

---
updated-dependencies:
- dependency-name: github.com/alecthomas/kong
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jessp01
Copy link
Author

jessp01 commented Aug 10, 2025

Anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant