Repair rubocop refusing to run (#97)#262
Open
sinfomicien wants to merge 1 commit into
Open
Conversation
sinfomicien
force-pushed
the
update-and-repair-extension
branch
from
e89f937 to
3519ab6
Compare
Open
sinfomicien
force-pushed
the
update-and-repair-extension
branch
from
3519ab6 to
6d617ee
Compare
sinfomicien
force-pushed
the
update-and-repair-extension
branch
from
6d617ee to
7402d95
Compare
- Upgrade dependencies - Use ESlint instead of TSLint(obsolete) - Remove a null token parameter in findFiles call, generating extension load error - Replace rootPath (deprecated) by workspaceFolders[0].uri.fsPath - Correct a language/snippet file loading problem(berkshelf vs berkfile) (chef#142) - Correct gif image url in README (master branch now is main) - Escape $ in some snippet description to avoid warning from VSCode Signed-off-by: Nicolas Blanc <sinfomicien@gmail.com>
sinfomicien
force-pushed
the
update-and-repair-extension
branch
from
7402d95 to
260aa8c
Compare
|
Author
|
@clintoncwolfe , is it possible to review this PR ? Could it be merged at some point ? |
Author
|
@nikhil2611 could you review the PR please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As i start to look into the problem, got multiples problem to handle. So i tried to correct them all:
Now, all problems are correctly highlighted (even if for now, it’s not possible to correct them automatically).
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.