feat: improving and simplifying the 1D assignment #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hamed-musallam
commented
Nov 20, 2025
hamed-musallam
commented
- improving and simplifying the 1D assignment to reduce ambiguity and ensure more consistent behavior.
- Assignments will now be handled exclusively at the signal level, rather than at the range level.
- Ranges will generally contain a single signal, except in cases where the user manually edits and another signal under the same range.
Deploying nmrium with
|
| Latest commit: |
3ca3dcd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://525c460e.nmrium.pages.dev |
| Branch Preview URL: | https://improve-1d-assignment.nmrium.pages.dev |
- improving and simplifying the 1D assignment to reduce ambiguity and ensure more consistent behavior. - Assignments will now be handled exclusively at the signal level, rather than at the range level. - Ranges will generally contain a single signal, except in cases where the user manually edits and another signal under the same range.
hamed-musallam
force-pushed
the
improve-1d-assignment
branch
from
b29f8ee to
0c76009
Compare
Member
|
@hamed-musallam There's a failing E2E test that's easy to reproduce (just draw where there is no peak):
|
targos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.