Remove deprecation note from ListLookup#2258
Closed
carlosedp wants to merge 1 commit intochipsalliance:masterfrom
Closed
Remove deprecation note from ListLookup#2258carlosedp wants to merge 1 commit intochipsalliance:masterfrom
carlosedp wants to merge 1 commit intochipsalliance:masterfrom
Conversation
Member
|
I'd like to deprecate this API, asking user switching to decoder API. Since this API will introduce a cascade Mux rather than parallel pla, which can be the critical path in most of CPU designs. So I still encourage designers switching to decoder for the this performance issue. |
Contributor
|
@sequencer Would you mind making a PR on @carlosedp chiselv design to show how to move to the decoder API? Then we could always point people to your change to show how to migrate. |
Member
|
carlosedp/chiselv#2 is sent. |
Member
|
A deprecation PR #2259 is sent, fell free to open this if @carlosedp has more questions ;p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment on
ListLookupdocumentation does not reflect current use of the API. As seen, the it's a pattern in use for Decoders on multiple cores like:And many others.
Contributor Checklist
docs/src?Type of Improvement
API Impact
No impact, documentation change.
Backend Code Generation Impact
No impact.
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.3.x, [small] API extension:3.4.x, API modification or big change:3.5.0)?Please Merge?