Skip to content

Conversation

@mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Feb 1, 2026

The intention for the next major release is to remove all legacy Ember APIs.

Previously, the disabled getter relied on ember/runloop. Additionally, it updated state during computation, which has long been considered an anti-pattern (ember/no-side-effects).

Since this release already introduces breaking changes, the code has been refactored to use modern Ember patterns.


Breaking change impact

In general, this change should not be breaking for most applications or common usage patterns.

It only affects apps that:

  • Use the public API without the trigger modifier, and
  • Change disabled from false to true

How to fix this in your app

Recommended solution
Use the trigger modifier. This is the preferred and supported approach.

Alternative solution
If using the trigger modifier is not possible, you must manually call:

actions.updatePublicApi();

after setting disabled: true in your code.

@mkszepp mkszepp merged commit 016ca44 into master Feb 1, 2026
17 checks passed
@mkszepp mkszepp deleted the remove-no-side-effects branch February 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants