concurrency issues#328
Merged
Merged
Conversation
bbortt
added
Type: Bug
READY
Type: Maintenance
TO REVIEW
Prio: High
java
bbortt
commented
May 13, 2025
bbortt
force-pushed
the
fix/concurrency-issues
branch
3 times, most recently
from
f98ef9c to
40dc0a3
Compare
tschlat
requested changes
May 14, 2025
bbortt
force-pushed
the
fix/concurrency-issues
branch
from
40dc0a3 to
849c916
Compare
it may occur that two scenarios run at the same time (with only a millisecond off). if that happens, the `Stack` implementation in `ScenarioEndpoint` does not respect FIFO order. the second message receives the output of the first.
bbortt
force-pushed
the
fix/concurrency-issues
branch
from
849c916 to
7d3d244
Compare
bbortt
force-pushed
the
fix/concurrency-issues
branch
from
7d3d244 to
39e67ff
Compare
this commit introduces a nice link between a scenario and its messages. an object is being attached to the `TestContext` which is unique per scenario execution. both the received `Message` as well as the response `Future` are contained in it.
bbortt
force-pushed
the
fix/concurrency-issues
branch
from
39e67ff to
9e8341e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it may occur that two scenarios run at the same time (with only a millisecond off).
if that happens, the
Stackimplementation inScenarioEndpointdoes not respect FIFO order.with using a queue, theoretically, the problem could now occur the other way around.
but it's much more unlikely.
only if simulation 2 finishes before simulation 1 we do still have a problem.
since this only occurs in equal simulations, it's likely that time constraints are also equal.
also includes a dependency upgrade to citrus core v4.6.0.