Align ctime/atime with mtime in inode attrs#17
Open
ThoolooExpress wants to merge 1 commit intocloudflare:mainfrom
Open
Align ctime/atime with mtime in inode attrs#17ThoolooExpress wants to merge 1 commit intocloudflare:mainfrom
ThoolooExpress wants to merge 1 commit intocloudflare:mainfrom
Conversation
Mirror `mtime` onto `atime` and `ctime` in FUSE inode attrs. Leaving them as `time.Time{}` produces a year-1 zero that overflows when serialized into the FUSE attr struct, and a `ctime` that disagrees with what git stored makes git's stat-cache treat every base file as potentially modified.
This addresses one of two causes of the "all files modified on fresh blobless-clone mount" symptom. The size=0 cause and the slowness of git's resulting content-check pass are addressed in follow-up PRs.
b02a691 to
c8c0c29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #16.
Mirror
mtimeontoatimeandctimein FUSE inode attrs. Leaving them astime.Time{}produces a year-1 zero that overflows when serialized into the FUSE attr struct, and actimethat disagrees with what git stored makes git's stat-cache treat every base file as potentially modified.This addresses one of two causes of the "all files modified on fresh blobless-clone mount" symptom. The size=0 cause and the slowness of git's resulting content-check pass are addressed in follow-up PRs.
🤖 Partially created with Claude code