Skip to content

Fix absolute symlinks in PHP artifact bundled libs #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanovac wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Fix absolute symlinks in PHP artifact bundled libs #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions internal/recipe/php.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,24 @@ func (p *PHPRecipe) setupTar(ec php.ExtensionContext, run runner.Runner) error {
}
}

// Fix any absolute symlinks in lib/ produced by `cp -a` from build hosts
// where system library symlinks are absolute (e.g. libgpg-error.so →
// /lib/x86_64-linux-gnu/libgpg-error.so.0 on cflinuxfs4). libbuildpack
// rejects absolute symlinks as a security measure, causing staging to fail
// with "cannot link to an absolute path when extracting archives".
fixSymlinks := fmt.Sprintf(
`find "%s/lib" -maxdepth 1 -type l | while IFS= read -r link; do
target=$(readlink "$link")
if [ "${target#/}" != "$target" ]; then
ln -sf "$(basename "$target")" "$link"
fi
done`,
phpPath,
)
if err := run.Run("sh", "-c", fixSymlinks); err != nil {
return fmt.Errorf("setup_tar: fix absolute symlinks: %w", err)
}

// Cleanup.
cleanup := fmt.Sprintf(
`rm -f "%s/etc/php-fpm.conf.default" && rm -f "%s/bin/php-cgi" && find "%s/lib/php/extensions" -name "*.a" -type f -delete`,
Expand Down