Don't JSON encode decimals as string #4807
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
json-decimal-encoding
branch
2 times, most recently
from
a115685 to
3d75f7d
Compare
- Use Oj consistently for encoding and decoding. - Remove custom encoder in JSON initializer. - Configure Oj to encode BigDecimals as JSON numbers. - Override BigDecimal's 'as_json' method; it's called by ActiveSupport and returns a string by default (before invoking the actual JSON encoder). - Adapt rescued error classes. - Add specs to test JSON encoding/decoding for service instance parameters (create, update, get) and service binding parameters (create, get).
philippthun
force-pushed
the
json-decimal-encoding
branch
from
3d75f7d to
bf743b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_jsonmethod; it's called by ActiveSupport and returns a string by default (before invoking the actual JSON encoder).Fixes #4799.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests