Direnv (.envrc) adds ./bin to path #4810
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Load the "init_block" of spec_helper pre-fork when using Spring
- Previously the init_block was only used by Spork.
- Spring would run it on every fork. This made tests load slower and
reduced the benefit of using Spring, since less was being preloaded
than could be.
- I blindly copied over the current init/run blocks, without
investigating in any depth. It's possible that more can be moved into
the "init" method, to further reduce test load times when using
Spring. This could be a worthwhile follow-up, especially if/when Spork
is removed.
- Extract out a SpecHelperHelper module so the "init_block" can be
shared between spec_helper and Spring
- Enforce that SpecHelperHelper.init only runs once. That way it doesn't
run post-fork, which is a minor performance improvement and means we
don't need to worry about everything in there being idempotent.
- Add documentation to spec/README
- So that the spring-ified rspec binary (and other spring binstubs) run by default - This makes tests run faster by default
Gerg
force-pushed
the
direnv_add_bin_to_path
branch
from
d6c69db to
b0da8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default
Continuation of #4802
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests