feat: upgrade to PHP 8.1 enums and optimize code quality#2
Merged
cclilshy merged 1 commit intocloudtay:mainfrom Mar 22, 2025
BadJacky:feat/php-8.1-enums-and-code-optimization
Merged
feat: upgrade to PHP 8.1 enums and optimize code quality#2cclilshy merged 1 commit intocloudtay:mainfrom BadJacky:feat/php-8.1-enums-and-code-optimization
cclilshy merged 1 commit intocloudtay:mainfrom
BadJacky:feat/php-8.1-enums-and-code-optimization
Conversation
- Refactor Status class from constants to PHP 8.1+ enum type - Add getMessage() and getMessageForCode() methods to replace static MESSAGES array - Fix duplicate Content-Length check in Connection class - Use (int) typecasting instead of intval() for better performance - Improve readability of conditional assignment statements - Update WaitGroup import path - Standardize code formatting and alignment
Contributor
Author
|
@cclilshy review please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Status class from constants to PHP 8.1+ enum type
Add getMessage() and getMessageForCode() methods to replace static MESSAGES array
Fix duplicate Content-Length check in Connection class
Use (int) typecasting instead of intval() for better performance
Improve readability of conditional assignment statements
Update WaitGroup import path
Standardize code formatting and alignment