-
Notifications
You must be signed in to change notification settings - Fork 208
refactor(volo-build): adapt to the codegen backend new trait and new codegen context defined in pilota-build #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8245272 to
ec08b79
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (11.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 41.96% 43.42% +1.46%
==========================================
Files 160 160
Lines 19806 19355 -451
==========================================
+ Hits 8311 8405 +94
+ Misses 11495 10950 -545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…codegen context defined in pilota-build Change-Id: I79680ac8fd6b4b657aa965f45c850a461bcc3ab4
…d related examples
…d related examples
a5bd2f5 to
e550e53
Compare
volo-http/Cargo.toml
Outdated
| "client", | ||
| "server", # core | ||
| "http1", | ||
| "http2", # protocol | ||
| "query", | ||
| "form", | ||
| "json", # serde | ||
| "tls", # https | ||
| "cookie", | ||
| "multipart", | ||
| "ws", # exts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里保留一下原有的样式吧,看着原来那么拆分是故意的;或者改成下面这样:
| "client", | |
| "server", # core | |
| "http1", | |
| "http2", # protocol | |
| "query", | |
| "form", | |
| "json", # serde | |
| "tls", # https | |
| "cookie", | |
| "multipart", | |
| "ws", # exts | |
| # core | |
| "client", | |
| "server", | |
| # protocol | |
| "http1", | |
| "http2", | |
| # serde | |
| "query", | |
| "form", | |
| "json", | |
| # https | |
| "tls", | |
| # exts | |
| "cookie", | |
| "multipart", | |
| "ws", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 这个是自动 fmt,我关掉
83d8484 to
f454caf
Compare
f454caf to
e3ee355
Compare
Change-Id: I79680ac8fd6b4b657aa965f45c850a461bcc3ab4
Motivation
We do some refactor for pilota-build in cloudwego/pilota#344 to solve the problem of maintainability.
Solution
Adapt to the new trait and struct defination.