Skip to content

Conversation

@Ggiggle
Copy link
Collaborator

@Ggiggle Ggiggle commented Oct 14, 2025

Change-Id: I79680ac8fd6b4b657aa965f45c850a461bcc3ab4

Motivation

We do some refactor for pilota-build in cloudwego/pilota#344 to solve the problem of maintainability.

Solution

Adapt to the new trait and struct defination.

@Ggiggle Ggiggle requested review from a team as code owners October 14, 2025 06:59
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 11.66667% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.42%. Comparing base (22d0d88) to head (e3ee355).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
volo-build/src/grpc_backend.rs 0.00% 34 Missing ⚠️
volo-build/src/thrift_backend.rs 0.00% 12 Missing ⚠️
volo-grpc/src/codec/encode.rs 36.36% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (11.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   41.96%   43.42%   +1.46%     
==========================================
  Files         160      160              
  Lines       19806    19355     -451     
==========================================
+ Hits         8311     8405      +94     
+ Misses      11495    10950     -545     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 104 to 114
"client",
"server", # core
"http1",
"http2", # protocol
"query",
"form",
"json", # serde
"tls", # https
"cookie",
"multipart",
"ws", # exts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里保留一下原有的样式吧,看着原来那么拆分是故意的;或者改成下面这样:

Suggested change
"client",
"server", # core
"http1",
"http2", # protocol
"query",
"form",
"json", # serde
"tls", # https
"cookie",
"multipart",
"ws", # exts
# core
"client",
"server",
# protocol
"http1",
"http2",
# serde
"query",
"form",
"json",
# https
"tls",
# exts
"cookie",
"multipart",
"ws",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 这个是自动 fmt,我关掉

@Ggiggle Ggiggle merged commit a7febd1 into main Nov 17, 2025
20 of 21 checks passed
@Ggiggle Ggiggle deleted the refactor/ast branch November 17, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants