Add feature-flagged optimistic updates for Check/NextClue#109
Draft
Add feature-flagged optimistic updates for Check/NextClue#109
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
optimisticDispatchplumbing and client-mutation-id tracking touseGameEngine, includingpendingMutationIdsbookkeeping, stale-mutation pruning, andapplyServerActionthat ignores server events with matchingclientMutationId. (Seeapp/engine/use-game-engine.ts.)optimisticDispatchon the engine context and wireuseSoloGameEngineto pass a no-op implementation so solo mode remains unchanged. (Seeapp/engine/use-engine-context.tsandapp/engine/use-solo-game-engine.ts.)?optimistic=1in the room loader and passoptimisticEnabledintouseGameEngineso optimistic updates can be enabled from the page. (Seeapp/routes/room.$roomName.tsx.)optimisticDispatchbefore submitting and attachclientMutationIdto form submissions, and extend their server routes to accept and persist an optionalclientMutationIdin the room event payloads. (Seeapp/components/prompt/check-form.tsx,app/components/prompt/next-clue-form.tsx,app/routes/room.$roomId.check.tsx, andapp/routes/room.$roomId.next-clue.tsx.)Testing
npm run formatwhich completed successfully.npm run lintwhich passed (there is one pre-existing ESLint warning inapp/utils/user-settings.tsx).npm run typecheckwhich succeeded.npm run test -- --run(Vitest) and all test suites passed.npm run validate; E2E stage failed to start due to missing environment keySUPABASE_SERVICE_ROLE_KEYin this environment, which prevented Playwright from starting the web server (code path unrelated to these changes).Codex Task