Skip to content

Fix: labeler args robustness, people insertion logic, and cartopy transform #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shbhmexe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: labeler args robustness, people insertion logic, and cartopy transform #113

shbhmexe wants to merge 1 commit into from

Conversation

@shbhmexe
Copy link

@shbhmexe shbhmexe commented Nov 25, 2025

This PR delivers a set of safe, focused improvements that increase stability and correctness without changing existing features:

  • Fixes a compilation/runtime issue in utilities/labeler by making the changed_files argument optional, correcting an issueNum variable name, guarding access to argv[0] when matching against a configured list, and replacing a brittle integer parse helper with strconv.Atoi. These changes prevent crashes and improve CLI ergonomics while preserving behavior.
  • Resolves duplicate/early-insert logic in Kubestronaut/CNCFInsertKubestronautInPeople_json.py so a new entry is only added if it does not already exist. The script now writes the sorted list back to people.json as intended.
  • Ensures Ambassadors/CNCFInsertAmbassadorInPeople_json.py appends at the end when a new name sorts after all existing entries, preventing silent no-op behavior.
  • Corrects the cartopy transform (PlateCarree for EPSG:4326 data) and guards the contextily basemap call to avoid runtime errors in Kubestronaut/Rendering/GenerateWorldTimelapseCartopy.py. Output remains the same except that failures to fetch/render a basemap will no longer crash the script.

Impact: Low-risk, focused fixes that improve stability and correctness. No functional features are added or removed.

Compatibility

  • No breaking changes. Existing workflows and scripts retain their intended behavior; failure modes are reduced.

@github-actions github-actions bot added toc toc specific issue needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied) needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) help wanted labels Nov 25, 2025
@shbhmexe
fix: robust labeler args; dedupe/append people; correct cartopy trans…
1d741e6 
…form

- utilities/labeler: make changed_files optional, fix variable name (issueNum), guard matchList arg access, replace toInt with strconv.Atoi
- Kubestronaut/CNCFInsertKubestronautInPeople_json.py: prevent duplicates, insert once, and write sorted output
- Ambassadors/CNCFInsertAmbassadorInPeople_json.py: append when new name sorts after all existing entries
- Rendering/GenerateWorldTimelapseCartopy.py: use PlateCarree transform; guard basemap call to avoid runtime errors

Signed-off-by: Shubham Shukla <[email protected]>
Signed-off-by: shbhmexe <[email protected]>
@shbhmexe shbhmexe force-pushed the fix/labeler-args-and-insert-logic branch from 43f3715 to 1d741e6 Compare November 25, 2025 11:19
@jeefy jeefy requested a review from huats December 1, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huats huats Awaiting requested review from huats

Assignees

No one assigned

Labels

help wanted needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied) toc toc specific issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shbhmexe