feat: handle ready_for_review webhook action#920
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 1316 1316
Lines 50643 50654 +11
Branches 1625 1625
=======================================
+ Hits 46541 46552 +11
Misses 3796 3796
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
| REOPENED = "reopened" | ||
| SYNCHRONIZE = "synchronize" | ||
| LABELED = "labeled" | ||
| EDITED = "edited" |
Contributor
There was a problem hiding this comment.
nit: alphabetize this list, and separate EDITED after (could even add whitespace before). I got confused and thought EDITED was part of PULLS_SYNC_ACTIONS
thomasrockhu-codecov
approved these changes
May 14, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHubPullRequestActionsconstants class towebhook_handlers/constants.pyready_for_reviewto the list of actions that triggerPullsSyncpull_request()handler to use the new constants instead of bare stringsTest plan
test_pull_request_ready_for_review_triggers_pulls_sync— verifiespulls_syncis called when action isready_for_reviewtest_pull_request_triggers_pulls_sync_task_for_valid_actions,test_pull_request_updates_title_if_edited,test_pull_request_exits_early_if_repo_not_activeCloses https://github.com/codecov/core-engineering/issues/64
🤖 Generated with Claude Code
Note
Low Risk
Low risk: small change to GitHub webhook routing that only expands the set of PR actions that enqueue
pulls_sync, with a focused unit test added.Overview
The GitHub
pull_requestwebhook now triggersTaskService().pulls_syncwhen the action isready_for_review, aligning behavior with other PR lifecycle actions.PR action handling is refactored to use a new
GitHubPullRequestActionsconstants class (including a sharedPULLS_SYNC_ACTIONSlist), and a test is added to assert the newready_for_reviewbehavior.Reviewed by Cursor Bugbot for commit 8ae9a82. Bugbot is set up for automated code reviews on this repo. Configure here.