feat(unstable): expose typed session selector/capability fields for clients#26
Conversation
- Bump schema/version and version to 0.10.8 - Refresh unstable schema - Regenerate types_gen.go (includes PromptResponse usage support)
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Thanks for the PR, @carsonfarmer. You’ll need to run |
|
You bet, and thanks for reviewing! |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
This PR makes session selector metadata reliably available in the typed Go surface, so clients can distinguish config selectors by identity (
id,name, etc.) instead of treating them as equivalent selects.Key changes
cmd/generate/internal/load/merge.go(+ tests): correctly promotes changed shared defs from unstable where needed.cmd/generate/internal/emit/types.go: includes shared parent object fields on generated union variant structs.unstable_types_test.gov0.10.8, committing regenerated schema/code outputs.Agentinterface (includingSetSessionConfigOption).Resulting typed surface improvements
SessionCapabilitiesnow carries typed unstable markers (fork,list,resume).NewSessionResponseincludes typed optionalconfigOptionsandmodels.UnstableResumeSessionResponseincludes typedconfigOptions,models, andmodes.SessionConfigOptionSelectincludes identity and UX metadata:id,name, optionaldescription, optionalcategorytype,currentValue,optionsValidation
gmake release VERSION=0.10.8(includes version/gen/fmt/test/check)go test ./...Notes