Render tests infrastructure#605
Draft
tritao wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@VolkerEnderlein I sent this as a draft so you can check and provide some feedback about this. My plans is to add a new modern rendering backend to Coin in the future, and this provides some testing infrastructure so we can make sure the new backend matches the existing one. If you don't agree with this or think a different design is warranted, please let me know and I'll try to make those changes. |
Member
|
That really looks impressive. I am happy to accept this PR if it is ready to merge. Thanks for your ongoing work to push forward coin development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a render-test harness (
CoinRenderTests) plus initial specs/scenes/baselines to support render regression testing.Why
The later renderer/GL backend changes are large and hard to validate by hand; having a repeatable render regression workflow early in the stack makes review and iteration much safer.
Changes
tools/CoinRenderTestsand hook it into the build.tests/render.thirdparty/whereami,thirdparty/stb).lighting_spotbaseline to match software-rendered CI output.Testing
-DRENDER_TESTS_ENABLED=ON; default is OFF).cmake -S . -B bld-rt-ci -G Ninja -DCMAKE_BUILD_TYPE=Release -DCOIN_BUILD_TESTS=OFF -DCOIN_BUILD_EXAMPLES=OFF -DRENDER_TESTS_ENABLED=ONcmake --build bld-rt-ci -j$(nproc)xvfb-run -a env LIBGL_ALWAYS_SOFTWARE=1 ctest --test-dir bld-rt-ci -R '^render_smoke$' --output-on-failure(passes)xvfb-run -a env LIBGL_ALWAYS_SOFTWARE=1 ctest --test-dir bld-rt-ci -R '^render_gl$' --output-on-failure(passes 12/12)Commits
da4a66ca66: Add render tests infrastructure.