You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @gardenia, thanks for the contribution. This command feels pretty un-unixy, which makes me think it's maybe not a good fit for this binary, but I'm open to discussing it. Are there usecases not covered by ls [-R] | wc?
the count command provides the convenience of reporting
Number dirs
Number files
Number bytes
For a particular path in a single command invocation
It uses an efficient single RPC call provided by the hdfs namenode (getContentSummary). So on a large cluster (large number of files/dirs) a ls -R may be many round trips and pulling back big listings just to compute the same information whereas this count implementation is just a single RPC
The "count" command is standard within hdfs and therefore is something users of the original Java Hadoop command line may be familiar with and have got used to relying upon (as I myself had)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic support for the count command:
https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/FileSystemShell.html#count
Currently no command-line options supported (other than -h) but I find this adds value to my own use-cases as is.