Skip to content

Conversation

@ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Nov 26, 2025

  • made the "In the box" section have the optional harness
  • switched to grid so that it is either a 2x2 grid or stacked versus having a widow item for certain screens sizes
  • also fixes items to be centered when they are stacked as seen in 2nd vid

Different screen sizes

added-harness.mp4

Fixes items to be centered when mobile

fixes-items-not-centered

@ugtthis
Copy link
Contributor Author

ugtthis commented Nov 26, 2025

Seems like the preview is failing because not enough channels
https://github.com/commaai/website/actions/runs/19694272857/job/56416086714

"message": "Couldn't create channel on `projects/959079472803/sites/comma-web`: channel quota reached.",
"status": "RESOURCE_EXHAUSTED"

@github-actions
Copy link
Contributor

deployed preview: https://comma-web--pr253-pp20jm3q.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

@sshane
Copy link
Contributor

sshane commented Nov 29, 2025

Fixes items to be centered when mobile

this is a separate PR!

@sshane
Copy link
Contributor

sshane commented Nov 29, 2025

optional sounds like you don't need it at all. you can maybe add it if the user selects a harness dynamically

@sshane
Copy link
Contributor

sshane commented Nov 29, 2025

Seems like the preview is failing because not enough channels

yeah, I lowered the exp time, it should improve soon. can't delete in their UI

@ugtthis
Copy link
Contributor Author

ugtthis commented Nov 30, 2025

Sounds good, I'll make these separate PRs. Added the fix to center items #258 for now

@ugtthis ugtthis closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants