feat(dns): support DoQ & DoH3#65
Merged
Merged
Conversation
Co-authored-by: DeepSeek <service@deepseek.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends cyper-hickory’s Hickory-based DNS connection provider to support DNS-over-QUIC (DoQ) and DNS-over-HTTP/3 (DoH3), adding the necessary transport implementations and feature flags.
Changes:
- Added new QUIC (DoQ) transport (
src/quic.rs) and HTTP/3 (DoH3) transport (src/h3.rs) behindquic/h3features. - Wired
ProtocolConfig::{Quic,H3}intoCompioConnectionProviderand shared the DoH MIME constant vialib.rs. - Updated crate features/dependencies and added integration tests for QUIC/H3 resolution.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cyper-hickory/tests/resolve.rs |
Adds QUIC and H3 resolver tests and server spawn support for those protocols. |
cyper-hickory/src/quic.rs |
Introduces a DoQ client stream implementation over compio::quic. |
cyper-hickory/src/h3.rs |
Introduces a DoH3 request sender over compio’s HTTP/3 client support. |
cyper-hickory/src/lib.rs |
Adds module wiring, ProtocolConfig matching for QUIC/H3, and a shared DoH MIME constant plus a QUIC connect helper. |
cyper-hickory/src/https.rs |
Uses the shared DoH MIME constant from lib.rs. |
cyper-hickory/Cargo.toml |
Adds quic/h3 feature flags and required optional deps. |
cyper-axum/Cargo.toml |
Switches compio-log to workspace dependency. |
Cargo.toml |
Adds compio-log to workspace dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.