Keep this repo up to date with ptomasroos module it was forked from. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing commas are not allowed after the rest element, this is not enforced by babel 6 but is by babel 7.
Fix invalid object rest syntax
Removed trailing comma, which is a breaking change for RN 0.56
use __getValue() instead of ._value
Update ScrollableTabsExample.js
Update SimpleExample.js
Update SimpleExample.js
* remove deprecated ViewPager * Update index.js Co-Authored-By: Mustafa Buyukcelebi <[email protected]>
* add @react-native-community/viewpager in package.json * modify ViewPagerAndroid to refer to @react-native-community/viewpager * change version of @react-native-community/viewpager to ^2.0.1
Bumps [diff](https://github.com/kpdecker/jsdiff) from 3.3.1 to 3.5.0. - [Release notes](https://github.com/kpdecker/jsdiff/releases) - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v3.3.1...v3.5.0) Signed-off-by: dependabot[bot] <[email protected]>
* adds passing onScroll to ScrollView in ScrollableTabBar * adds throttle to onScroll events of the underlying ScrollView
`onPageSelected={this._updateSelectedPage}` ViewPager prop causes onTabChange to be called twice when change tabs without any gesture actions
this will fix duplicated tab updates on android
#### when user clicked tab buttons
`goToPage -> updateSceneKeys(onTabChange) -> Screen Update -> onPageSelected={_updateSelectedPage} -> updateSceneKeys(onTabChange) -> Screen Update`
#### when user swiped tab views
`Swipe -> onPageSelected={_updateSelectedPage} -> updateSceneKeys(onTabChange) -> Screen Update`
#### when user clicked tab buttons with this patch
`goToPage -> set tabWillChangeWithoutGesture -> updateSceneKeys(onTabChange) -> Screen Update -> onPageSelected={_updateSelectedPage} -> ignore updateSceneKeys(onTabChange) -> remove tabWillChangeWithoutGesture`
…ineStyle] (#1055) tabBarUnderlineStyle was not working on default tab bar because it was excepting tabUnderlineStyle prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a need to keep this forked module up to date with the latest commits on ptomasroos original repo?