fix: enable pointerEvents during swiping#55
fix: enable pointerEvents during swiping#55cloudorbush wants to merge 1 commit intocomputerjazz:mainfrom
Conversation
solves issue computerjazz#48 with proposed solution from @jmif here computerjazz#48 (comment)
|
Just tested as well and working for us! |
| : closestSnapPoint > 0 | ||
| ? OpenDirection.RIGHT | ||
| : OpenDirection.LEFT; | ||
| runOnJS(setOpenDirection)(openDirection) |
There was a problem hiding this comment.
strange that this fixes the issue, any idea why?
I would expect this to be exactly the same as calling setOpenDirection on the first line in onAnimationEnd
What about all the other cases that onAnimationEnd is called? Wouldn't removing setOpenDirection cause incorrect state in those cases?
There was a problem hiding this comment.
So the issue are seeing is that the underlay is not intractable until after the animation is finished so if the user tries to press a button in the underlay while animation is "easing out" it wont work because pointer events are disabled here and this value isn't updated until the animation is completely finished. So the fix here is the underlay being intractable when the animation starts and this accomplishes that by setting the open direction sooner than it did before. I'm not sure about downstream issues from this but wanted to chime in with context as to what this is solving / why it solves.
There was a problem hiding this comment.
can you try 2.0.8 and see if it fixes this issue?
3 participants
solves issue #48 with proposed solution from @jmif here #48 (comment)