-
-
Notifications
You must be signed in to change notification settings - Fork 307
How to: Maintain several versions #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| Open your `conda-forge.yml` file and add these lines: | ||
|
|
||
| ```yaml | ||
| abi_migration_branches: # TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It this a TODO for the doc or meant literally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, nop, I missed this. Added in 9d27f98
mgorny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, though I think we may want to call out the following behaviour that can be annoying/surprising:
Creating a branch off of an old commit and adding it to abi_migration_branches will almost certainly cause the bot to create a whole bunch of pointless migrator PRs against that new branch, because the logic for when to create such a migrator PR is very sensitive to even the most minor rerender changes, which will almost always trigger for old commits (i.e. stuff that hasn't been rerendered in a while).
I still think it would be good to avoid this by double-rerendering for the maintenance branches, see regro/cf-scripts#2500
|
Good to know. I'll add a quick note but perhaps we should focus on fixing that surprising behavior too. |

PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileCloses Quansight-Labs/conda-ecosystem-sta-mgmt#63