-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding Resourcecode python package #31406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/resourcecode/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19136694985. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge/help-python, ready for review! |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
synapticarbors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in the upstream setup.py, it has python_requires=">=3.9, <3.13". If this package is going to break with python 3.14, then you should put an upper bound on python under run:
- python >={{ python_min }},<3.14
Otherwise this looks good.
|
thanks @synapticarbors, indeed AFAIK the package is not working on python from 3.13 for the moment, so I fixed the version on the recipe. Could it be changed after if we manage to soften this constraint ? |
This recipe has been prepared using greyskull , from pypi package 'resourcecode'.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).