Skip to content

Conversation

@jaimergp
Copy link
Contributor

Checklist for submitter

  • I am submitting a new CEP: conda-lock.yml lockfiles.
    • I am using the CEP template by creating a copy cep-0000.md named cep-XXXX.md in the root level.
  • I am submitting modifications to CEP XX.
  • Something else: (add your description here).

Checklist for CEP approvals

  • The vote period has ended and the vote has passed the necessary quorum and approval thresholds.
  • A new CEP number has been minted. Usually, this is ${greatest-number-in-main} + 1.
  • The cep-XXXX.md file has been renamed accordingly.
  • The # CEP XXXX - header has been edited accordingly.
  • The CEP status in the table has been changed to approved.
  • The last modification date in the table has been updated accordingly.
  • The table in the README has been updated with the new CEP entry.
  • The pre-commit checks are passing.

@jaimergp
Copy link
Contributor Author

cc @maresb, lmk what you think!

Copy link

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken an initial quick pass and this looks pretty good. Ping @basnijholt.

I think it may be helpful to provide the following additional context:

There's a "unique" constraint on the package list with key (name, manager, platform, category).

Currently known producers:

Currently known consumers:

  • conda-lock install, micromamba env create


## References

- <https://github.com/conda/conda-lock/blob/v3.0.4/conda_lock/lockfile/v1/models.py>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the ref here once we cut the next release, since we change version from ClassVar to Literal[1].

@jaimergp
Copy link
Contributor Author

Thanks for the prompt review!

There's a "unique" constraint on the package list with key (name, manager, platform, category).

Added in ee2dff0.

Actually md5 and sha256 are technically optional.

Reworded in a6d58bc.

Currently known producers:

Thanks! Added in 1202623. Note that conda-lockfiles is also a thing now.

Copy link

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I've wished for this for a long time, and it's great to finally have it.

All my feedback (apart from the future version bump in the conda-lock link) has been incorporated. I made another pass and didn't notice any further issues.

Thanks again @jaimergp!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CEP: conda-lock files

2 participants