-
Notifications
You must be signed in to change notification settings - Fork 30
Add CEP for conda-lock.yml lockfiles
#138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @maresb, lmk what you think! |
maresb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken an initial quick pass and this looks pretty good. Ping @basnijholt.
I think it may be helpful to provide the following additional context:
There's a "unique" constraint on the package list with key (name, manager, platform, category).
Currently known producers:
conda-lock lock, https://github.com/basnijholt/pixi-to-conda-lock
Currently known consumers:
conda-lock install,micromamba env create
|
|
||
| ## References | ||
|
|
||
| - <https://github.com/conda/conda-lock/blob/v3.0.4/conda_lock/lockfile/v1/models.py> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the ref here once we cut the next release, since we change version from ClassVar to Literal[1].
|
Thanks for the prompt review!
Added in ee2dff0.
Reworded in a6d58bc.
Thanks! Added in 1202623. Note that |
maresb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I've wished for this for a long time, and it's great to finally have it.
All my feedback (apart from the future version bump in the conda-lock link) has been incorporated. I made another pass and didn't notice any further issues.
Thanks again @jaimergp!!!
Checklist for submitter
conda-lock.ymllockfiles.cep-0000.mdnamedcep-XXXX.mdin the root level.Checklist for CEP approvals
${greatest-number-in-main} + 1.cep-XXXX.mdfile has been renamed accordingly.# CEP XXXX -header has been edited accordingly.pre-commitchecks are passing.