Remove * from valid version characters
#60
Conversation
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Nice! Thanks for this @AntoinePrv ! 👍 🥇
It might also be worth mentioning that this behavior has already partially been deprecated in the use of VersionSpec in conda as mentioned here:
log.warning(
"Using .* with relational operator is superfluous and deprecated "
"and will be removed in a future version of conda. Your spec was "
"{}, but conda is ignoring the .* and treating it as {}".format(
vo_str, vo_str[:-2]
)
)
cep-xx.md
Outdated
| This is the most delicate part to handle since ``>1.7*`` is frequently use to mean greater than the | ||
| ``1.7`` infimum (could also be writen as ``=1.7|>=1.7``, that is, mathching some versions smaller | ||
| than ``1.7.0``, such as ``1.7alpha``). |
There was a problem hiding this comment.
Existing cases here are often caused by someone accidentally using =>1.7* in a recipe instead of >=1.7*. I vote we should interpret it as what is most likely intended here (e.g. >=1.7*).
jaimergp
left a comment
jaimergp
left a comment
There was a problem hiding this comment.
Thank you for this interesting write up! I am in agreement with the spirit of the changes.
I found a typo here and there, and I'd also like to highlight the capitalization standards for conda and conda-forge:
|
Hi all, How can I move this forward? Is there a meeting I should attend to champion this? |
4 participants
📄 Rendered version
We recommend to remove
*from validVersioncharacters, due to confusing intersection withVersionSpecglob expressions.We suggest different possibilities on how the character could be reinterpreted in
VersionSpecwith an analysis on backward compatibility.