fix(pgpm): stop deploy on 'No modules found' error and use consistent module discovery #486
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module discovery - Fix deploy command to handle undefined return from selectPackage by stopping execution with an error message instead of continuing - Add context-aware package selection (similar to tag.ts pattern): - Use --package if explicitly specified - Use current module if running from inside a module - Prompt for package selection if in workspace with recursive mode - Fix selectPackage to use getModuleMap() instead of getModules() for consistency with how core deploy discovers modules (via .control files) - Fix logOnly and fast flags to use prompted values instead of argv values (was causing logOnly to default to true when flag was absent)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
pgpm deploy --createdbwould log "No modules found in the specified directory" but continue executing instead of stopping. The deploy command now properly handles the error case and uses consistent module discovery with the core deploy logic.Key changes:
selectPackagereturns undefined (no modules found)selectPackageto usegetModuleMap()instead ofgetModules()- the former scans for.controlfiles directly while the latter uses pgpm.json patterns, which could miss nested modulestag.tscommand patternfastandlogOnlyflags which were incorrectly defaulting to true when not specifiedReview & Testing Checklist for Human
pgpm deploy --createdb --database testdband verify it now prompts for package selection instead of showing error then continuingpgpm deploy --package mymoduleworks correctly--logOnlyflag and confirm it actually executes SQL (not just logging)getModuleMapvsgetModules) could behave differently in complex workspace structuresNotes
The root cause was a mismatch between how the CLI discovers modules (
getModules()using pgpm.json patterns) vs how core deploy discovers them (getModuleMap()scanning for .control files). In nested workspaces like startkit-example-workspace, the CLI would find no modules while core deploy would find them via .control file scanning.Link to Devin run: https://app.devin.ai/sessions/5d6fa89b81314b06842a9c19ddcfcd62
Requested by: Dan Lynch (@pyramation)