Security: Validate accent_color to prevent CSS injection#55
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Security: Validate accent_color to prevent CSS injection#55bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
…color validation
The existing validation already prevents CSS injection by enforcing the format
/\A#[0-9a-fA-F]{6}\z/, which only allows valid 6-character hex colors.
Changes:
- Added nil guard to accent_color_rgb method to prevent crashes
- Created comprehensive test suite to verify:
- Valid hex colors are accepted (upper and lowercase)
- CSS injection attempts are rejected
- XSS attempts with </style> tags are rejected
- Invalid color formats are rejected
- Nil values are handled gracefully
Fixes #17
Co-authored-by: Philip I. Thomas <philipithomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CSS injection vulnerability in
_account_accent_color_override.html.erbis already mitigated by existing validation in the Account model:This PR adds defensive improvements and a comprehensive test suite to ensure the fix is documented and protected against regression.
Changes
accent_color_rgbmethod to prevent crashesred; } body { display:none } .x {)</style><script>)Security Analysis
The existing validation is sufficient because:
\Aand\z) to match entire string#followed by exactly 6 hex charactersCloses #17