Fix: Use validation context for drafts instead of skipping validations#59
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Fix: Use validation context for drafts instead of skipping validations#59bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
Replace save!(validate: false) with save!(context: :draft) to maintain data integrity while allowing drafts to be saved without subject/body. - Add draft_context? method to Post model - Make presence validations conditional on validation context - Length validation still enforced (max 255 chars for subject) Closes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
DraftController#update, drafts were saved withsave!(validate: false)which bypasses all model validations. This is dangerous because it allows any data to be saved to the database, including data that violates length constraints or other integrity checks.Solution
Use Rails validation contexts to selectively skip only the presence validations when saving drafts:
save!(validate: false)tosave!(context: :draft)draft_context?method to Post modelsubjectpresence,body_cannot_be_empty) conditional withunless: :draft_context?Benefits
validate: falseCloses #23